Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dap): has_package -> is_installed #97

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(dap): has_package -> is_installed #97

merged 1 commit into from
Dec 14, 2023

Conversation

bas-ie
Copy link
Contributor

@bas-ie bas-ie commented Dec 13, 2023 •
edited
Loading

This:

  • switches out has_package for is_installed when checking Mason for the presence of codelldb.

has_package is true if the package is in the Mason registry, which is not quite what we want here. This fixes an error in the case where Mason is installed, but codelldb is not.

Fixes #96

@bas-ie
fix(dap): has_package -> is_installed
5233396 
has_package is true if the package is in the Mason registry, which is
not quite what we want here.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited by mrcjkb
Loading

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@bas-ie bas-ie changed the title has_package -> is_installed fix(dap): has_package -> is_installed Dec 13, 2023
mrcjkb
mrcjkb approved these changes Dec 14, 2023
View reviewed changes
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrcjkb mrcjkb merged commit b76ae2a into mrcjkb:master Dec 14, 2023
5 checks passed
@bas-ie bas-ie deleted the fix/lldb-path branch December 14, 2023 10:53
This was referenced Nov 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcjkb mrcjkb mrcjkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lldb path apparently broken by versions after around 3.7.1
2 participants
@bas-ie @mrcjkb